Hi all,

I have noticed a small (but annoying) issue wrt Gmaven.

If one of the Groovy classes has the following structure:

/**
 * some info
 */
package foo
/*
 * some other info
 */
public class A {
}

We get a 'syntax error @[9,1] in UNKNOWN SOURCE' message during 'mvn install' (see complete message under [1]). IMO, it should not be possible to crash Gmaven with exotic comments (although it's not usual to have javadoc comments before the package def and non-javadoc ones before the class). Plus the error message should at least mention the source file where the error occured.

Any thoughts?

Cheers,
Patrick


P.S. Test project in attachment. Just unpack and run 'mvn install'.


[1] Complete stack trace

$ mvn -e install
+ Error stacktraces are turned on.
[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[INFO] Building Unnamed - GmavenTest:GmavenTestC:jar:0.0.1-SNAPSHOT
[INFO]   task-segment: [install]
[INFO] ------------------------------------------------------------------------
[INFO] [groovy:generateStubs {execution: gmaven-generateStubs}]
[INFO] ------------------------------------------------------------------------
[ERROR] BUILD ERROR
[INFO] ------------------------------------------------------------------------
[INFO] syntax error @[9,1] in UNKNOWN SOURCE

[INFO] ------------------------------------------------------------------------
[INFO] Trace
org.apache.maven.lifecycle.LifecycleExecutionException: syntax error
@[9,1] in UNKNOWN SOURCE
    at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals (DefaultLifecycleExecutor.java:584)
    at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle (DefaultLifecycleExecutor.java:500)
    at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal (DefaultLifecycleExecutor.java:479)
    at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures (DefaultLifecycleExecutor.java:331)
    at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments (DefaultLifecycleExecutor.java:292)
    at org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute (DefaultLifecycleExecutor.java:142)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:345)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:132)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:290)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:39)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:25)
    at java.lang.reflect.Method.invoke (Method.java:597)
    at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
    at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
    at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
    at org.codehaus.classworlds.Launcher.main(Launcher.java:375)
Caused by: org.apache.maven.plugin.MojoExecutionException: syntax
error @[9,1] in UNKNOWN SOURCE
    at org.codehaus.gmaven.plugin.MojoSupport.execute(MojoSupport.java:85)
    at org.codehaus.gmaven.plugin.stubgen.AbstractGenerateStubsMojo.execute(AbstractGenerateStubsMojo.java:60)
    at org.apache.maven.plugin.DefaultPluginManager.executeMojo (DefaultPluginManager.java:454)
    at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals (DefaultLifecycleExecutor.java:559)
    ... 16 more
Caused by: com.thoughtworks.qdox.parser.ParseException: syntax error
@[9,1] in UNKNOWN SOURCE
    at com.thoughtworks.qdox.parser.impl.Parser.yyerror(Parser.java:992)
    at com.thoughtworks.qdox.parser.impl.Parser.yyparse(Parser.java:1298)
    at com.thoughtworks.qdox.parser.impl.Parser.parse(Parser.java:973)
    at com.thoughtworks.qdox.JavaDocBuilder.addSource (JavaDocBuilder.java:313)
    at com.thoughtworks.qdox.JavaDocBuilder.addSource (JavaDocBuilder.java:303)
    at org.codehaus.gmaven.runtime.support.stubgen.model.JavaDocParser.parseWithQDox(JavaDocParser.java:79)
    at org.codehaus.gmaven.runtime.support.stubgen.model.JavaDocParser.parse(JavaDocParser.java:55)
    at org.codehaus.gmaven.runtime.support.stubgen.model.ModelFactorySupport.javadocs(ModelFactorySupport.java:858)
    at org.codehaus.gmaven.runtime.support.stubgen.model.ModelFactorySupport.classDef(ModelFactorySupport.java:263)
    at org.codehaus.gmaven.runtime.support.stubgen.model.ModelFactorySupport.process(ModelFactorySupport.java:125)
    at org.codehaus.gmaven.runtime.support.stubgen.model.ModelFactorySupport.create(ModelFactorySupport.java:90)
    at org.codehaus.gmaven.runtime.support.stubgen.model.ModelFactorySupport.create(ModelFactorySupport.java:61)
    at org.codehaus.gmaven.runtime.v1_6.StubCompilerFeature$StubCompilerImpl.render(StubCompilerFeature.java:101)
    at org.codehaus.gmaven.runtime.v1_6.StubCompilerFeature$StubCompilerImpl.compile(StubCompilerFeature.java:90)
    at org.codehaus.gmaven.plugin.stubgen.AbstractGenerateStubsMojo.compile(AbstractGenerateStubsMojo.java:160)
    at org.codehaus.gmaven.plugin.stubgen.AbstractGenerateStubsMojo.process(AbstractGenerateStubsMojo.java:131)
    at org.codehaus.gmaven.plugin.ComponentMojoSupport.doExecute(ComponentMojoSupport.java:60)
    at org.codehaus.gmaven.plugin.MojoSupport.execute(MojoSupport.java:69)
    ... 19 more

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

  http://xircles.codehaus.org/manage_email